[BUG] VERILATOR_INSTALL_DIR is not set proprely in setup-env.sh

[Mabdalshakour]

Is there an existing CVA6 bug for this?

• I have searched the existing bug issues

Bug Description

In setup-env.sh line 45, VERILATOR_INSTALL_DIR is set to "$ROOT_PROJECT"/tools/verilator which doesn't take the VERILATOR_HASH into account like what install-verilator.sh does in line 40, where it sets it to $ROOT_PROJECT/tools/verilator-$VERILATOR_HASH. That makes verilator unreachable except for running smoke-tests.sh. You can't source setup-env.sh as a standalone.

[valentinThomazic]

Maybe I am failing to see the issue but I don't see it on the current latest commit (ab2283c) since the verif/regress/install-verilator.sh script will install the binary in tools/verilator/bin which is the default path in the verif/sim/setup-env.sh script.
Please confirm you are still encountering the issue on ab2283c

[JeanRochCoulon]

@Mabdalshakour We are cleaning the "Github Issues". I assume this issue is closed. May I ask you to close it ?