Skip to content

Commit 03d66d9

Browse files
committed
8358572: C1 hits "need debug information" assert with -XX:-DeoptC1
Reviewed-by: shade, aph
1 parent f6ff38a commit 03d66d9

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

src/hotspot/share/c1/c1_Compilation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ ciKlass* Compilation::cha_exact_type(ciType* type) {
668668
if (type != nullptr && type->is_loaded() && type->is_instance_klass()) {
669669
ciInstanceKlass* ik = type->as_instance_klass();
670670
assert(ik->exact_klass() == nullptr, "no cha for final klass");
671-
if (DeoptC1 && UseCHA && !(ik->has_subklass() || ik->is_interface())) {
671+
if (UseCHA && !(ik->has_subklass() || ik->is_interface())) {
672672
dependency_recorder()->assert_leaf_type(ik);
673673
return ik;
674674
}

src/hotspot/share/c1/c1_GraphBuilder.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1855,7 +1855,6 @@ void GraphBuilder::access_field(Bytecodes::Code code) {
18551855

18561856

18571857
Dependencies* GraphBuilder::dependency_recorder() const {
1858-
assert(DeoptC1, "need debug information");
18591858
return compilation()->dependency_recorder();
18601859
}
18611860

@@ -2001,7 +2000,7 @@ void GraphBuilder::invoke(Bytecodes::Code code) {
20012000
ciMethod* cha_monomorphic_target = nullptr;
20022001
ciMethod* exact_target = nullptr;
20032002
Value better_receiver = nullptr;
2004-
if (UseCHA && DeoptC1 && target->is_loaded() &&
2003+
if (UseCHA && target->is_loaded() &&
20052004
!(// %%% FIXME: Are both of these relevant?
20062005
target->is_method_handle_intrinsic() ||
20072006
target->is_compiled_lambda_form()) &&
@@ -2252,7 +2251,7 @@ bool GraphBuilder::direct_compare(ciKlass* k) {
22522251
if (ik->is_final()) {
22532252
return true;
22542253
} else {
2255-
if (DeoptC1 && UseCHA && !(ik->has_subklass() || ik->is_interface())) {
2254+
if (UseCHA && !(ik->has_subklass() || ik->is_interface())) {
22562255
// test class is leaf class
22572256
dependency_recorder()->assert_leaf_type(ik);
22582257
return true;

src/hotspot/share/c1/c1_globals.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,6 @@
244244
develop(bool, GenerateArrayStoreCheck, true, \
245245
"Generates code for array store checks") \
246246
\
247-
develop(bool, DeoptC1, true, \
248-
"Use deoptimization in C1") \
249-
\
250247
develop(bool, PrintBailouts, false, \
251248
"Print bailout and its reason") \
252249
\

0 commit comments

Comments
 (0)