Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve client/server instance injection #515

Open
alcarney opened this issue Nov 26, 2024 · 1 comment
Open

Improve client/server instance injection #515

alcarney opened this issue Nov 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alcarney
Copy link
Collaborator

There are some situations where pygls does not correctly detect when it should inject the client/server instance into a feature handler

See swyddfa/lsp-devtools#195 (comment)
@alcarney alcarney added the bug Something isn't working label Nov 26, 2024
@eliericha
Copy link

I see the issue at https://github.com/openlawlibrary/pygls/blob/main/pygls/feature_manager.py#L64

The code checks for an exact match between the client type and the parameter annotation when it should use issubclass() somehow.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alcarney @eliericha