Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump to version 1.2 #89

Closed
2 tasks done
jackiehanyang opened this issue Nov 16, 2021 · 4 comments
Closed
2 tasks done

Bump to version 1.2 #89

jackiehanyang opened this issue Nov 16, 2021 · 4 comments
Assignees

Comments

@jackiehanyang
Copy link
Collaborator

jackiehanyang commented Nov 16, 2021

CI/CD

  • Increment version on main to 1.2.0.0.
  • Ensure working and passing CI.
@jackiehanyang
Copy link
Collaborator Author

Current error when try to upgrade version to 1.2

* What went wrong:
Could not determine the dependencies of task ':opensearch-ml-plugin:thirdPartyAudit'.
> Could not resolve all files for configuration ':opensearch-ml-plugin:runtimeClasspath'.

   > Could not find org.opensearch:common-utils:1.2.0.0.

@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Nov 16, 2021

Try

  1. Add maven repo maven { url "https://aws.oss.sonatype.org/content/repositories/snapshots" }
  2. Use opensearch_version = "1.2.0-SNAPSHOT" and common_utils_version = '1.2.0.0-SNAPSHOT'

./gradlew build passed locally , check this commit

@ylwu-amzn ylwu-amzn changed the title Release version 1.2 Bump to version 1.2 Nov 16, 2021
@jackiehanyang
Copy link
Collaborator Author

The issue is I missed the repositories setting file which is is located in a separate file and applied to build.gradle file. After addressing this, building 1.2 version with downloading dependencies SNAPSHOTs from Maven passed successfully.

Version bumping PR - #90

@jackiehanyang
Copy link
Collaborator Author

Need to look into why Checks in PR are somehow not getting triggered, It will be triggered by push though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants