Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Source (_source) input parameter has confusing type #158

Closed
tmewett opened this issue Sep 15, 2022 · 5 comments
Closed

Source (_source) input parameter has confusing type #158

tmewett opened this issue Sep 15, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@tmewett
Copy link

tmewett commented Sep 15, 2022

The _source input parameter is encoded in the API as type []string.

This is consistent with API docs like update document which have it as type List - but not with their description which has "Default is true" and implies it is a Boolean.

In the end I had to specify true as []string{"true"}, which doesn't seem very ergonomic. Not to mention that it's unclear what would happen if I had a field called "true".

Thank you 🙇‍♂️

related opensearch-project/documentation-website#1237

@wbeckler wbeckler added the good first issue Good for newcomers label Jan 18, 2023
@zethuman
Copy link
Contributor

zethuman commented Apr 5, 2023

Hey there, I want to solve this issue if it is actual. But this will affect a lot of APIs, so I need more time to refactor and write tests for each of them. If solution is required, please assign this issue to me

@whym9
Copy link

whym9 commented Apr 5, 2023

I am also interested in solving this issue. @zethuman, I can help you with this problem. Would you be interested in teaming up?

@wbeckler
Copy link

wbeckler commented Apr 7, 2023

Both of you feel free to collaborate and work on this. Also, please identify whether this will break any working code that relies on the old setup. If so, we would want to merge this into the 3.x line.

@zethuman
Copy link
Contributor

zethuman commented Apr 14, 2023

Can we close this issue by merge [#285]?

@dblock
Copy link
Member

dblock commented Apr 17, 2023

Yep, closing.

@dblock dblock closed this as completed Apr 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants