-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Source (_source) input parameter has confusing type #158
Comments
Hey there, I want to solve this issue if it is actual. But this will affect a lot of APIs, so I need more time to refactor and write tests for each of them. If solution is required, please assign this issue to me |
I am also interested in solving this issue. @zethuman, I can help you with this problem. Would you be interested in teaming up? |
Both of you feel free to collaborate and work on this. Also, please identify whether this will break any working code that relies on the old setup. If so, we would want to merge this into the 3.x line. |
Can we close this issue by merge [#285]? |
Yep, closing. |
The _source input parameter is encoded in the API as type
[]string
.This is consistent with API docs like update document which have it as type List - but not with their description which has "Default is true" and implies it is a Boolean.
In the end I had to specify true as
[]string{"true"}
, which doesn't seem very ergonomic. Not to mention that it's unclear what would happen if I had a field called "true".Thank you 🙇♂️
related opensearch-project/documentation-website#1237
The text was updated successfully, but these errors were encountered: