Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LOG-6758: fix invalid forwarder for lokiStack #2973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Feb 27, 2025

Description

This PR:

  • fixes the false validation error when writting multiple log_types to a lokiStack output
  • introduces a lokistack output generate to replace the initialization logic that was pre-validation
  • builds OTLP config based upon logsource
  • fixes OTLP grouping of node logs to include grouping by host
  • fixes the forwarder-generator

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025

@jcantrill: This pull request references LOG-6758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • fixes the false validation error when writting multiple log_types to a lokiStack output
  • introduces a lokistack output generate to replace the initialization logic that was pre-validation
  • builds OTLP config based upon logsource
  • fixes OTLP grouping of node logs to include grouping by host

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@openshift-ci openshift-ci bot requested review from cahartma and vparfonov February 27, 2025 19:19
Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025

@jcantrill: This pull request references LOG-6758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • fixes the false validation error when writting multiple log_types to a lokiStack output
  • introduces a lokistack output generate to replace the initialization logic that was pre-validation
  • builds OTLP config based upon logsource
  • fixes OTLP grouping of node logs to include grouping by host
  • fixes the forwarder-generator

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

@jcantrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target 8e592dc link true /test functional-target

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. release/6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants