[WIP] Add container command execution proposal #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| A user must be able to specify the container or containers in which the requested command should run and/or the port forwarding should occur. A container is uniquely identified by the combination of a namespace, a pod name, and a container name. | ||
|
|
||
| Here are possible ways to specify one more more containers: |
There was a problem hiding this comment.
Should "one more more" be "one or more"?
There was a problem hiding this comment.
Yes to "one or more".
We won't support port forwarding to multiple containers. But we should consider supporting executing a command in multiple containers.
ncdc
force-pushed
the
remote-command-execution
branch
from
cdfc8cd to
13bdf8e
Compare
|
|
||
| There are multiple ways to copy data between the client and the container. Below are 3 possibilities. | ||
|
|
||
| #### Port Forwarding Command: `nsenter` + external helper |
There was a problem hiding this comment.
You called this out as not being considered up above, but then have something here. Clarify. (leaving this section in is probably better than taking it out)
There was a problem hiding this comment.
Where did I say it isn't being considered?
There was a problem hiding this comment.
Nm, I misread: "more than one".
Remove OpenShift specifics. Clarify questions.
Update which capabilities are required.
|
Moved upstream |
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
* correct bug in keyer * fix wrong kind in broker list * add mocked out k8s core apisever client for tpr testing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.