Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Icons responsiveness #11

Closed
diego-rapoport opened this issue Apr 22, 2024 · 3 comments · Fixed by #12
Closed

Icons responsiveness #11

diego-rapoport opened this issue Apr 22, 2024 · 3 comments · Fixed by #12
Assignees
@ackle-dev
Labels
enhancement New feature or request

Comments

@diego-rapoport
Copy link
Contributor

So I was thinking that the responsiveness of the icons ate the bottom were not very good. So I made some changes and it seems better now. I also removed one div from the HTML.
Please give feedback on this and if you guys think that's a valid change.
@diego-rapoport
Copy link
Contributor Author

I already linked the branch I worked on in this issue.

@ackle-dev
Copy link
Member

That's great that you've helped out!

We can't see your changes though, would you mind opening a pull request?

@ackle-dev
Copy link
Member

oh my bad, just found it.

@diego-rapoport diego-rapoport linked a pull request Apr 22, 2024 that will close this issue
Fix responsiveness of icons #12
Merged
@ackle-dev ackle-dev self-assigned this Sep 18, 2024
@ackle-dev ackle-dev added the enhancement New feature or request label Sep 18, 2024
@ackle-dev ackle-dev pinned this issue Sep 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ackle-dev ackle-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix responsiveness of icons opensource-force/site
2 participants
@diego-rapoport @ackle-dev