Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Try fetching the snapshot URI without user/pass if it fails #88

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Try fetching the snapshot URI without user/pass if it fails #88

merged 9 commits into from
Jan 23, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 23, 2025 •
edited
Loading

Some camera don't like mixing the user/pass in the query and using basic/digest auth

@bdraco bdraco changed the title Log failing snapshot URI to improve debug Try fetching the snapshot URI without user/pass if it fails Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onvif/client.py 18.18% 9 Missing ⚠️
Files with missing lines Coverage Δ
onvif/util.py 75.00% <100.00%> (+12.50%) ⬆️
onvif/client.py 54.44% <18.18%> (-0.34%) ⬇️

@bdraco bdraco marked this pull request as ready for review January 23, 2025 00:29
@bdraco bdraco merged commit 6779c5d into async Jan 23, 2025
6 checks passed
@bdraco bdraco deleted the failing_snapshot_uri branch January 23, 2025 00:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco