From 26fc418bf5597b17c07168b3811de8942e8ebd3f Mon Sep 17 00:00:00 2001
From: Dhanus <dhanus3133@gmail.com>
Date: Tue, 23 Jul 2024 22:19:30 +0530
Subject: [PATCH] [ci] Run tests even when QA fails

---
 .github/workflows/ci.yml | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index cbfa08a..98f0fab 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,16 +48,12 @@ jobs:
           spatialite-bin \
           libsqlite3-mod-spatialite
 
-      - name: Install npm dependencies
-        run: sudo npm install -g jshint stylelint
-
-      - name: Install python dependencies
+      - name: Install Dependencies
+        id: deps
         run: |
           pip install -U pip wheel setuptools
           pip install -U -r requirements-test.txt
-
-      - name: Install openwisp-firmware-upgrader
-        run: |
+          sudo npm install -g jshint stylelint
           pip install -U -e .
           pip install ${{ matrix.django-version }}
 
@@ -66,12 +62,14 @@ jobs:
           ./run-qa-checks
 
       - name: Tests
+        if: ${{ !cancelled() && steps.deps.conclusion == 'success' }}
         run: |
           coverage run -a --source=openwisp_firmware_upgrader runtests.py
           # SAMPLE_APP tests do not affect coverage so can be run in parallel to speed up
           SAMPLE_APP=1 ./runtests.py --parallel
 
       - name: Upload Coverage
+        if: ${{ success() }}
         run: coveralls --service=github
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}