-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
'generate openapi' - CRD name and group are wrong #1608
Comments
/cc @estroz |
@jpkrohling were these CRDs generated with the SDK? The behavior should have been the same when looking at the commits in the SDK, |
I had the impression that the newest was generated via the SDK's generator, but I might be wrong. How is the name composed? Is there something I could change in the Jaeger Operator in order to get the SDK regenerate the proper CRD? |
@jpkrohling when I delved into the issue further I figured out that the controller-tools CRD generator was getting the incorrect domain for |
Bug Report
When running
operator-sdk generate openapi
against the Jaeger Operator, the CRD's name and group are overridden, from the originaljaegers.jaegertracing.io
/jaegertracing.io
tojaegers.jaegertracing.jaegertracing
/jaegertracing.jaegertracing
.What did you do?
Executed
operator-sdk generate openapi
against an existing operator (Jaeger's).Environment
operator-sdk version:
v0.8.1, commit: 33b3bfe10176f8647f5354516fff29dea42b6342
go version:
go1.12.5 linux/amd64
Kubernetes version information:
Kubernetes cluster kind: minikube
Are you writing your operator in
ansible, helm, or go?Additional context
This can be reproduced by running
make generate
in the following Jaeger Operator branch:https://github.com/jpkrohling/jaeger-operator/tree/466-ValidateCR
The text was updated successfully, but these errors were encountered: