Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add flag metrics-addr for Helm/Ansible #3358

Closed
camilamacedo86 opened this issue Jul 8, 2020 · 0 comments
Closed

Add flag metrics-addr for Helm/Ansible #3358

camilamacedo86 opened this issue Jul 8, 2020 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project
Milestone

Comments

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Jul 8, 2020

Feature Request

The new helm layout is working with the current/legacy image of the operator-sdk helm. This image is not allowing users to customize the metrics port.

We need to:

        
	pflag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
        ... 
       options := ctrl.Options{
		MetricsBindAddress:      metricsAddr,
		LeaderElection:          enableLeaderElection,
		LeaderElectionID:        leaderElectionID,
		LeaderElectionNamespace: leaderElectionNamespace,
		NewClient:               manager.NewDelegatingClientFunc(),
	}

Important: we should scaffold the projects to use by default the same go/kb port in order to keep a standard across all projects and then, describe in the migration guide how the users are able to still use the current port and no face breaking changes if they wish.

@camilamacedo86 camilamacedo86 added language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project kind/feature Categorizes issue or PR as related to a new feature. kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form labels Jul 8, 2020
@camilamacedo86 camilamacedo86 added this to the v1.0.0 milestone Jul 8, 2020
@estroz estroz closed this as completed Jul 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project
Projects
None yet
Development

No branches or pull requests

2 participants