Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ansible Operator Should use status writer #540

Closed
shawn-hurley opened this issue Sep 26, 2018 · 2 comments
Closed

Ansible Operator Should use status writer #540

shawn-hurley opened this issue Sep 26, 2018 · 2 comments
Assignees
@shawn-hurley
Labels
blocked language/ansible Issue is related to an Ansible operator project

Comments

@shawn-hurley
Copy link
Member

per @hasbro17 comment on PR #473

Don't need to change this now but it might be worth looking into the Status client to see if there's a benefit to using that if we're just updating the status:
kubernetes-sigs/controller-runtime:pkg/client/unstructured_client.go@master#L136-L151
The default manager client comes with a status writer:
kubernetes-sigs/controller-runtime:pkg/client/split.go@master#L32
@shawn-hurley shawn-hurley added the language/ansible Issue is related to an Ansible operator project label Sep 26, 2018
@shawn-hurley shawn-hurley self-assigned this Sep 26, 2018
@shawn-hurley shawn-hurley mentioned this issue Sep 26, 2018
Merged
@shawn-hurley
Copy link
Member Author

Moving this to blocked. We want the ansible operator to support k8s 1.10 which means that the status subresource is not on by default.

@joelanford
Copy link
Member

Closed by #787

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@shawn-hurley shawn-hurley

Labels
blocked language/ansible Issue is related to an Ansible operator project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelanford @shawn-hurley