Review comments

Author: tkrodriguez

compiler/mx.compiler/mx_graal_tools.py

@@ -80,10 +80,11 @@ def run_netbeans_app(app_name, jdkhome, args=None, dist=None):
 def igv(args):
     """run the Ideal Graph Visualizer
 
-    The current version is based on NetBeans 22 which officially supports JDK 17 through JDK 22.  A
+    The current version is based on NetBeans 26 which officially supports JDK 17 through JDK 24.  A
     supported JDK will be chosen from the JDKs known to mx but it will fall back to whatever is
     configured as JAVA_HOME if a supported JDK can't be found.  It's not recommended to run igv with
-    pre-release JDKs.
+    pre-release JDKs.  Setting TOOLS_JAVA_HOME to point at a supported JDK is the recommended way to
+    configure the JDK for IGV.
 
     You can directly control which JDK is used to launch IGV using
 
@@ -120,6 +121,7 @@ def _do_not_abort(msg):
                 mx.warn(f'mx help igv provides more details.')
 
     v24 = mx.VersionSpec("24")
+    # check for jargraal by looking for modules that are used by jdk.graal.compiler.
     if jdk.version >= v24 and 'org.graalvm.word' in (jmd.name for jmd in jdk.get_modules()):
         # disable JVMCI if jargraal is available to avoid collision with jdk.graal.compiler.graphio
         args.append('-J-XX:-UseJVMICompiler')

visualizer/Readme.md

@@ -2,15 +2,15 @@
 
 ## Prerequisites
 
-- JDK 21 is the recommended Java runtime platform for IGV, but any release between 17 and 22 is
-  supported by the NetBeans 22 platform.
+- JDK 21 is the recommended Java runtime platform for IGV, but any release between 17 and 24 is
+  supported by the NetBeans 24 platform.
 
 ## Building and testing IGV
 
 ### MX
 
 IGV is an MX project and for convenience should be built and tested as such.  It's also a NetBeans
-22 project based on Maven so it can be developed using any tool chain which supports Maven.
+26 project based on Maven so it can be developed using any tool chain which supports Maven.
 Certains kind of edits, like editing the NetBeans module exlusions or editing the special UI
 components, will require using NetBeans.