Skip to content

Commit

Permalink
Minor: remove outdated EpilogReturn comment, fix typo on manual bench…
Browse files Browse the repository at this point in the history
…mark interpreter
  • Loading branch information
DSouzaM committed Nov 21, 2024
1 parent 49623e2 commit 7aa5dc9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ protected Object executeAt(VirtualFrame frame, int startBci, int startSp) throws
}
// (i -- )
case OP_RETURN: {
return FRAMES.expectObject(frame, sp - 1);
return FRAMES.expectInt(frame, sp - 1);
}
default:
CompilerDirectives.shouldNotReachHere();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3838,12 +3838,7 @@ private void addEndOperationDoc(OperationModel operation, CodeExecutableElement
lines.add("<p>");
lines.add(getOperationSignatureJavadoc(operation));

if (model.epilogReturn != null && operation == model.epilogReturn.operation) {
lines.add("<p>");
lines.add(String.format(
"NB: This method does not directly emit %s instructions. Instead, {@link #beforeEmitReturn} uses the operation stack entry to determine that each Return should be preceded by a %s instruction.",
operation.name, operation.name));
} else if (operation.kind == OperationKind.TAG) {
if (operation.kind == OperationKind.TAG) {
lines.add("<p>");
lines.add("The tags passed to this method should match the ones used in the corresponding {@link #beginTag} call.");
}
Expand Down

0 comments on commit 7aa5dc9

Please # to comment.