Rationalize some metrics 1.1 and 2.0 support code; add sync to both impls #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng MetricProducer and Registry more in line with the metrics/metrics counterparts; add synchronization to metrics 1.1 and 2.0 support
2 tasks
spericas
approved these changes
Sep 30, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bring the 1.1 and 2.0 metrics support code more closely in alignment, particularly the registry implementations. They also remove from
metrics2/metrics2theflexiblesetting (and related code) added earlier toHelidonMetadata.The resulting
Registrycode is clearer (I hope):getOrRegisterMetricandgetOrRegisterMetadata, as their names suggest, retrieve an existing and compatible instance if available and create one otherwise. Those methods are also refactored and simplified a bit.and 'registerMetadatado just that, without checking for pre-existing instances.These changes also add thread-safeness to the 1.1 and 2.0 registries.