Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up visibility and JavaDoc for metrics #1075

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Clean up visibility and JavaDoc for metrics #1075

merged 1 commit into from
Oct 2, 2019

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Oct 1, 2019

Some artifacts in metrics need to be public (for use from other modules) but developers should not use them. Others were defined as public but can be more restrictive.

This PR changes the visibility for some items and suppresses JavaDoc for ones that must remain public (such as MetricsMpService and MetricsCdiExtension which are loaded as Java services).

Fixes #1060

Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit fef197b into helidon-io:master Oct 2, 2019
@tjquinno tjquinno deleted the cleanup-metrics-javadoc branch October 2, 2019 18:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Review metrics classes/interfaces for proper visibility and JavaDoc generation
2 participants