Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Tracing nesting and outbound security #1082

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Fix Tracing nesting and outbound security #1082

merged 3 commits into from
Oct 7, 2019

Conversation

tomas-langer
Copy link
Member

Resolves #879
Resolves #1045
Resolves #994

@tomas-langer
Make sure the traced interceptor honors active span.
d3956a5 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Make sure outbound tracing honors active span.
ac80e19 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer self-assigned this Oct 7, 2019
@tomas-langer
Outbound security tracing now correctly created for each outbound req…
93b116b 
…uest.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
spericas approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit d5be815 into helidon-io:master Oct 7, 2019
@tomas-langer tomas-langer deleted the 879-tracing branch October 7, 2019 22:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@spericas spericas spericas approved these changes

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@tomas-langer tomas-langer

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tomas-langer @spericas