Changes to metrics to work with MP metrics 2.2 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Gauges must apply to Numbers again
tjquinno
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicroProfile is working on releasing metrics 2.2. Its only change is to fix the backward-incompatible change that restricted gauges. According to their current PR this is the only change they are reverting; other compatible changes added in 2.1.0 will remain in 2.2.
This PR adapts Helidon to that change.
The initial set of changes alters the dependencies to refer to MP metrics 2.0.2. That release has the same restriction on gauges that 2.2 will but also lacks some minor (compatible!) changes from 2.1.0 which 2.2 will also have. In a future commit (once metrics 2.2 is available) I will update the dependency and fix a few temporary TODO items that work around the temporarily-missing enhancements that will return in 2.2.
Until then this PR will remain WIP and will not be merged.
Addresses #1116