Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use static factory methods instead of constructors wherever possible for gRPC classes #1128

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

thegridman
Copy link
Collaborator

Wherever possible constructors in classes in gRPC modules have been replaced with static factory methods. Classes where this could not be done are predominantly those that are discovered using a ServiceLoader.

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit d57efea into helidon-io:master Oct 30, 2019
@thegridman thegridman deleted the factory-methods branch October 30, 2019 15:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants