Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change the name of the workflow process identifiers #765

Closed
ebocher opened this issue Sep 19, 2022 · 2 comments · Fixed by #766
Closed

Change the name of the workflow process identifiers #765

ebocher opened this issue Sep 19, 2022 · 2 comments · Fixed by #766

Comments

@ebocher
Copy link
Member

ebocher commented Sep 19, 2022

Currently the outputs of the identifiers have the names : outputTableBuildingIndicators, outputTableBlockIndicators ...
I propose to change these names for more consistency and simplicity.

e.g :
building_indicators instead of outputTableBuildingIndicators
block_indicators instead of outputTableBlockIndicators
building instead of buildingTableName

From a GeoClimate workflow, you will have

getResults().output["Pont-de-Veyle"]["road_traffic"]

["Pont-de-Veyle"] = identifier of the location

["road_traffic"] = identifier for the result table

@j3r3m1 @ELSW56

@j3r3m1
Copy link
Collaborator

j3r3m1 commented Sep 19, 2022

Sounds reasonable

@ELSW56
Copy link
Contributor

ELSW56 commented Sep 20, 2022

To my mind, it's a good simplification, and the use of "_" instead of capital letters makes the name more readable.

@ebocher ebocher mentioned this issue Sep 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants