Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A possible typo in a doc formula of chainjnttojacdotsolver #367

Open
torydebra opened this issue Oct 27, 2021 · 2 comments
Open

A possible typo in a doc formula of chainjnttojacdotsolver #367

torydebra opened this issue Oct 27, 2021 · 2 comments

Comments

@torydebra
Copy link

Hi, I was just wondering about some documentation in the chainjnttojacdotsolver

/**
* @brief Computes \f$ \frac{\partial J^{i,ee}}{\partial q^{j}}.\dot{q}^{j} \f$
*
* @param bs_J_bs The Jacobian expressed in the base frame with the end effector as the reference point
* @param joint_idx The indice of the current joint (j in the formula)
* @param column_idx The indice of the current column (i in the formula)
* @param representation The representation (Hybrid,Body-fixed,Inertial) in which you want to get dJ/dqj .qdotj
* @return Twist The twist representing dJi/dqj .qdotj
*/
const Twist& getPartialDerivative(const Jacobian& J,
const unsigned int& joint_idx,
const unsigned int& column_idx,
const int& representation);

I see that the formula written is $ \frac{\partial J^{i,ee}}{\partial q^{j}}.\dot{q}^{j} $, but I am not sure that the final $\dot{q}^{j}$ should be there.
Indeed in :

// Column J is the sum of all partial derivatives ref (41)
if(!locked_joints_[j])
jac_dot_k_ += getPartialDerivative(jac_,j,k,representation_) * q_in.qdot(j);

The result of getPartialDerivative is multiplied by qdot(j)

I am using these formulas/codes, so I would just like to be sure about what it is happening inside :D

Thanks!

@MatthijsBurgh
Copy link
Collaborator

I don't have the formulas ready to me. @meyerj @smits could you take this one?

@traversaro
Copy link
Contributor

I guess also @ahoarau may know something as the original author of the class.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants