Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: emit events through tracing #1244

Merged
merged 1 commit into from
Feb 16, 2023
Merged

feat: emit events through tracing #1244

merged 1 commit into from
Feb 16, 2023

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Feb 15, 2023

This PR adds event emmission to check, expand, and the write APIs for relationships.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from zepatrik as a code owner February 15, 2023 11:56
@hperl hperl self-assigned this Feb 15, 2023
@hperl hperl requested a review from alnr February 15, 2023 11:57
@hperl
Copy link
Collaborator Author

hperl commented Feb 15, 2023

@alnr please check adherence to the events naming convention.

@hperl hperl force-pushed the hperl/ketoctx-tracer branch from 07fab3a to f0af8f2 Compare February 16, 2023 12:28
@hperl hperl force-pushed the hperl/ketoctx-tracer branch from f0af8f2 to 872e5c1 Compare February 16, 2023 12:30
@hperl hperl added this pull request to the merge queue Feb 16, 2023
Merged via the queue into master with commit 70dd8be Feb 16, 2023
@hperl hperl deleted the hperl/ketoctx-tracer branch February 16, 2023 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants