Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: pluralize issues number #125

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

dipsylala
Copy link
Contributor

@dipsylala dipsylala commented Jun 22, 2023

Displays '2 issues' rather than '2 issue' if multiple issues have been found by an advisory source.

Pluralize tested against:
https://www.npmjs.com/package/react-scripts
https://pypi.org/project/openpyxl-templates/

Checking for regression issues against the following, which should show singular issues in one of the artifacts.
https://www.npmjs.com/package/react-day-picker
https://www.npmjs.com/package/node-sass
https://pypi.org/project/pydub/

Lint output:

xxxxxxxxxxxxxx:~/Projects/overlay$ npm run lint

> lint
> eslint src tests e2e

yarn test output:

Test Suites: 12 passed, 12 total
Tests:       1 skipped, 193 passed, 194 total
Snapshots:   0 total
Time:        5.022 s
Ran all test suites.
Done in 5.98s.

Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See you in the next PR!!

ThankYouGIF

@dipsylala dipsylala changed the title Pluralize issue label when necessary feat: pluralize issues Jun 23, 2023
@baruchiro baruchiro changed the title feat: pluralize issues fix: pluralize issues number Jun 23, 2023
@baruchiro baruchiro merged commit 1c3a8a8 into os-scar:master Jun 23, 2023
@dipsylala dipsylala deleted the pluralize_issue_label branch June 23, 2023 12:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants