-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Overlay didn't display "npmjs" pages that do not contain a repository element #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
You did good work, but I want some changes. Please comment if you have any questions.
Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com>
I resolve conversations in the lest commit. content.npmjs.js - use more safe another selector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
If you're trying to support yarn
v3, please explain
Which version of |
We're using version 1 |
OK. I run I revert the I will not ignore it now from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix issue 148.
#148
content.npmjs.js - mount Overlay based on h3 element title "install" instead of repository element.
utils.js - if the element is not in the page. reject timeout after 10 seconds.
make bugs like this more easy to detect next time.
.gitignore - not pull cache and autogenerated files