Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Failed to sign the apk with keystore.properties #1534

Open
Bambooin opened this issue Dec 16, 2024 · 3 comments
Open

Failed to sign the apk with keystore.properties #1534

Bambooin opened this issue Dec 16, 2024 · 3 comments

Comments

@Bambooin
Copy link
Collaborator

Failed to build the signed apk by command make release.

Regression with commit 3feacc5, I revert some files to fix it right now.

git checkout 3feacc5~1 app/build.gradle.kts
git checkout 3feacc5~1 build-logic/convention/src/main/kotlin/ApkRelease.kt
@WhiredPlanck
Copy link
Collaborator

DONT DO THAT. We now use environment variables to replace keystore.properties, because on CI, reading secrets to write a keystore.properties is equivalent to setting them to environment variables.

@Bambooin
Copy link
Collaborator Author

I prefer the keystore.properties, as we can set multiple keystore files for different projects.

If we want to use environment, then we should update the build setcion of README.md.

@WhiredPlanck
Copy link
Collaborator

I prefer the keystore.properties, as we can set multiple keystore files for different projects.

Hm, I didn't consider this situation. If it's necessary, I will make it back later, or I will update README.md. But I have gone for a business trip that will take me about a week to finish my work, so it's not going to start on any time soon.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants