Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add amenity=place_of_worship #5232

Open
arch0345 opened this issue Aug 14, 2021 · 5 comments · May be fixed by #5960
Open

Add amenity=place_of_worship #5232

arch0345 opened this issue Aug 14, 2021 · 5 comments · May be fixed by #5960
Labels
considering Not Actionable - still considering if this is something we want new category Add support for a new kind of feature

Comments

@arch0345
Copy link
Collaborator

This would be helpful for places of worship operated by a common party, such as The Church of Jesus Christ of Latter-day Saints and Kingdom Hall of Jehovah's Witnesses. Recommend to also add landuse=religious to the operator tree using the same operators. iD presets already include Kingdom Hall of Jehovah's Witnesses without any operator tags, so that should be removed if this were to be added to the index.

@1ec5
Copy link
Member

1ec5 commented Aug 14, 2021

If I’m not mistaken, these denominations are tagged using denomination, not necessarily operator. (For LDS churches, I’ve been using operator to be more specific and indicate the ward if known.)

@arch0345
Copy link
Collaborator Author

That's true, most places of worship use denomination instead of operator. I've also been using operator for LDS churches. Would this mean adding a 'denomination' tree?

@arch0345 arch0345 changed the title Adding amenity=place_of_worship to operator tree Add amenity=place_of_worship Aug 14, 2021
@1ec5
Copy link
Member

1ec5 commented Aug 14, 2021

Maybe. Given the recent discussion about catholic=* on the tagging list, I’m not sure there’s any appetite for indiscriminate tagging of denomination:wikidata. That key is used in some cases of very small, obscure denominations (often with long names unsuitable for keyword-style tagging), but these denominations would probably be too small to justify an entry in NSI (with the most common value currently having just 19 occurrences as of writing). Would this project be open to a tree that doesn’t use Wikidata at all but just serves as a more comprehensive, machine-readable copy of the denomination wiki page?

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Aug 14, 2021
@bhousel
Copy link
Member

bhousel commented Aug 14, 2021

but these denominations would probably be too small to justify an entry in NSI (with the most common value currently having just 19 occurrences as of writing).

I've been adding small transit operators into NSI. (<10 instances are collected automatically, but even one-offs are welcome if it helps make the map better). I've found that the size of the index really isn't an issue.

Would this project be open to a tree that doesn’t use Wikidata at all but just serves as a more comprehensive, machine-readable copy of the denomination wiki page?

No, everything is built around wikidata right now, so I'd really prefer to create a new tree with a mainTag that's something:wikidata=*.

(update: here are the values taginfo collected for denomination, so this is what NSI would collect from the planet too)

@1ec5
Copy link
Member

1ec5 commented Aug 14, 2021

I've been adding small transit operators into NSI. (<10 instances are collected automatically, but even one-offs are welcome if it helps make the map better). I've found that the size of the index really isn't an issue.

That makes sense for public transit operators, which are easy to filter by geography, but small denominations can often be scattered worldwide with, say, one or two places of worship per country. The size of the index may not be an issue, but scrolling through a lot of matches for, say, “Church of Christ” or “Church of Jesus Christ” could be quite inconvenient unless NSI were to provide search result ranking hints to editors. Most denominations don’t have easily distinguishable logos, so one might have to do a bit of research to choose the right one.

@bhousel bhousel added the new category Add support for a new kind of feature label Aug 24, 2021
@arch0345 arch0345 linked a pull request Dec 30, 2021 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
considering Not Actionable - still considering if this is something we want new category Add support for a new kind of feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants