Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Using the delimiter "::" in a name should be an error in SDFormat 1.8 #420

Closed
azeey opened this issue Nov 18, 2020 · 1 comment · Fixed by #515
Closed

Using the delimiter "::" in a name should be an error in SDFormat 1.8 #420

azeey opened this issue Nov 18, 2020 · 1 comment · Fixed by #515
Assignees
@jennuine
Milestone
SDFormat 1.8 / li...

Comments

@azeey
Copy link
Collaborator

azeey commented Nov 18, 2020

Per the SDFormat 1.8 composition proposal, the :: delimiter is reserved for forming scopes, thus, it should not be used in name attributes. However, SDFormat 1.7 files can contain :: in name attributes as a result of model flattening. So, we should only emit an error if the file is SDFormat 1.8.
@azeey azeey self-assigned this Nov 18, 2020
@azeey azeey added this to the SDFormat 1.8 / libsdformat11 milestone Nov 18, 2020
@azeey azeey mentioned this issue Nov 18, 2020
Merged
@azeey azeey mentioned this issue Jan 12, 2021
Merged
@EricCousineau-TRI
Copy link
Collaborator

Requires #411 before we can make this change.

@EricCousineau-TRI EricCousineau-TRI assigned jennuine and unassigned azeey Feb 11, 2021
@jennuine jennuine mentioned this issue Mar 16, 2021
Merged
7 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jennuine jennuine

Labels
None yet
Projects
None yet
Milestone
SDFormat 1.8 / libsdformat11
Development

Successfully merging a pull request may close this issue.

Error when delimiter "::" found in element name in SDFormat 1.8 gazebosim/sdformat
3 participants
@azeey @jennuine @EricCousineau-TRI