Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix compile http-parser-2.1 fallthrouth error above gcc7 #1312

Closed
wants to merge 1 commit into from
Closed

Fix compile http-parser-2.1 fallthrouth error above gcc7 #1312

wants to merge 1 commit into from

Conversation

yss-al
Copy link

@yss-al yss-al commented Jan 26, 2019 •
edited
Loading

by the way, I format some spaces in the shell, sorry for my obession
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/Warning-Options.html#index-Wimplicit-fallthrough

@winlinvip winlinvip changed the base branch from master to 3.0release February 2, 2019 05:50
@winlinvip winlinvip changed the base branch from 3.0release to 2.0release February 2, 2019 05:51
@winlinvip
Copy link
Member

winlinvip commented Apr 5, 2019 •
edited
Loading

Won't fix for SRS2. SRS3 doesn't exist this issue.

@winlinvip winlinvip closed this Apr 5, 2019
@winlinvip
Copy link
Member

winlinvip commented Apr 5, 2019 •
edited
Loading

Fixed by a554dd8 in 2.0.263

It's a common error for #1065 #1159 #1220 #1154 #1129, and searched by many users:

image

Build SRS 2.0 on Ubuntu18:

git co 2.0release && ./configure

It will fail at:

image

We could remove the -Werror from CFLAGS += -Wall -Wextra -Werror to avoid this error.

@winlinvip winlinvip reopened this Apr 5, 2019
winlinvip referenced this pull request Apr 5, 2019
@winlinvip
Fix GCC7 build error, this statement may fall through. 2.0.263
a554dd8
@winlinvip winlinvip closed this Apr 5, 2019
@yss-al yss-al deleted the master branch April 19, 2019 13:46
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@winlinvip winlinvip winlinvip left review comments

Assignees
No one assigned
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yss-al @winlinvip