-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
HTTP: Fix 2GB+ mp4/flv file downloading error. #2809
HTTP: Fix 2GB+ mp4/flv file downloading error. #2809
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.0release #2809 +/- ##
===========================================
Coverage 60.30% 60.30%
===========================================
Files 121 121
Lines 50999 50999
===========================================
Hits 30753 30753
Misses 20246 20246 | Impacted Files | Coverage Δ | |' Translated to English while maintaining the markdown structure: '| Impacted Files | Coverage Δ | | ' Translated to English while maintaining the markdown structure: '| trunk/src/protocol/srs_http_stack.hpp | Continue to review full report at Codecov.
Translated to English while maintaining the markdown structure: '>
|
{ | ||
srs_error_t err = srs_success; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find a way to undo this modification, it should be automatically changed by the editor.
This is a significant disruption to reviewing PRs, I don't know what has been changed.
In the future, if someone wants to review this commit, it will also be very difficult, there are too many disruptions.
TRANS_BY_GPT3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I have made some modifications again, removing the changes that affect the review. I have also deleted the unnecessary merge commit logs using the rebase method. Thanks to Boss Yang for the PR guidance document How to File PR and Pro Git.
)
TRANS_BY_GPT3
b9757c4
to
208e2e9
Compare
NICE 👍 |
Background: #2780 #2781, when distributing large files (such as flv, mp4) through HTTP service, connection timeout or overflow logs may occur.
Reason: After exceeding 2GB, the
int
type cannot fully represent the file size.TRANS_BY_GPT3