Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

HTTP: Fix 2GB+ mp4/flv file downloading error. #2809

Merged

Conversation

chundonglinlin
Copy link
Member

@chundonglinlin chundonglinlin commented Dec 23, 2021

Background: #2780 #2781, when distributing large files (such as flv, mp4) through HTTP service, connection timeout or overflow logs may occur.
Reason: After exceeding 2GB, the int type cannot fully represent the file size.


TRANS_BY_GPT3

@chundonglinlin chundonglinlin changed the title HTTP: Fix mp4/flv file size excceed 2GB download error HTTP: Fix mp4/flv file size exceed 2GB download error Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #2809 (208e2e9) into 4.0release (faf5fb0) will not change coverage.
The diff coverage is 62.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           4.0release    #2809   +/-   ##
===========================================
  Coverage       60.30%   60.30%           
===========================================
  Files             121      121           
  Lines           50999    50999           
===========================================
  Hits            30753    30753           
  Misses          20246    20246           

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/protocol/srs_http_stack.hpp | 100.00% <ø> (ø) | |
| trunk/src/protocol/srs_service_http_conn.cpp | 94.37% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_static.cpp | 45.79% <55.55%> (ø) | |
| trunk/src/protocol/srs_http_stack.cpp | 92.83% <70.58%> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/protocol/srs_http_stack.hpp | 100.00% <ø> (ø) | |
| trunk/src/protocol/srs_service_http_conn.cpp | 94.37% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_static.cpp | 45.79% <55.55%> (ø) | |
| trunk/src/protocol/srs_http_stack.cpp | 92.83% <70.58%> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update faf5fb0...208e2e9. Read the comment docs.

TRANS_BY_GPT3

{
srs_error_t err = srs_success;

Copy link
Member

@winlinvip winlinvip Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a way to undo this modification, it should be automatically changed by the editor.

This is a significant disruption to reviewing PRs, I don't know what has been changed.

In the future, if someone wants to review this commit, it will also be very difficult, there are too many disruptions.

TRANS_BY_GPT3

Copy link
Member Author

@chundonglinlin chundonglinlin Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have made some modifications again, removing the changes that affect the review. I have also deleted the unnecessary merge commit logs using the rebase method. Thanks to Boss Yang for the PR guidance document How to File PR and Pro Git.
)

TRANS_BY_GPT3

@winlinvip winlinvip self-assigned this Dec 24, 2021
@winlinvip winlinvip added this to the 4.0 milestone Dec 24, 2021
@chundonglinlin chundonglinlin force-pushed the hotfix/http_fetch_file_error branch from b9757c4 to 208e2e9 Compare December 24, 2021 05:42
@winlinvip
Copy link
Member

NICE 👍

@winlinvip winlinvip linked an issue Dec 25, 2021 that may be closed by this pull request
@winlinvip winlinvip merged commit e73d002 into ossrs:4.0release Dec 25, 2021
@winlinvip winlinvip changed the title HTTP: Fix mp4/flv file size exceed 2GB download error HTTP: Fix 2GB+ mp4/flv file downloading error. Dec 25, 2021
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP: Failed to download large file recorded with 2GB.
3 participants