Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Has there been any omission in the code for organizing RTCP NACK packets? #2959

Closed
Lei-Xiangyu opened this issue Mar 8, 2022 · 3 comments · Fixed by #2966
Closed

Has there been any omission in the code for organizing RTCP NACK packets? #2959

Lei-Xiangyu opened this issue Mar 8, 2022 · 3 comments · Fixed by #2966
Assignees
@chen-guanghua
Labels
TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.

Comments

@Lei-Xiangyu
Copy link

Lei-Xiangyu commented Mar 8, 2022 •
edited by winlinvip
Loading

Note: Before asking a question, please read the FAQ (Please read FAQ before filing an issue) #2716

Is the first packet that exceeds the blp range after a nack packet pid missing?

Please describe the issue you encountered.

image
Did you forget to process this sequence after the first (sn - pid) > 16 here?

TRANS_BY_GPT3
@winlinvip winlinvip added the WebRTC WebRTC, RTC2RTMP or RTMP2RTC. label Mar 12, 2022
@chen-guanghua
Copy link
Contributor

chen-guanghua commented Mar 13, 2022 •
edited by winlinvip
Loading

Confirmed, after determining (sn - pid) > 16, no processing was done on seq.

TRANS_BY_GPT3

@chen-guanghua
Copy link
Contributor

chen-guanghua commented Mar 13, 2022 •
edited by winlinvip
Loading

The problem has been fixed and the PR has been submitted for this issue: #2966.

TRANS_BY_GPT3

@chen-guanghua chen-guanghua mentioned this issue Mar 13, 2022
Merged
@winlinvip winlinvip linked a pull request Mar 15, 2022 that will close this issue
bugfix: fix rtcp nack blp encode bug #2966
Merged
@winlinvip
Copy link
Member

Merged. Thanks 👍

@winlinvip winlinvip changed the title 整理rtcp的nack包的代码是否出现了遗漏 Has there been any omission in the code for organizing RTCP NACK packets? Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@chen-guanghua chen-guanghua

Labels
TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: fix rtcp nack blp encode bug chen-guanghua/srs
3 participants
@winlinvip @chen-guanghua @Lei-Xiangyu