Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fd leak when fork: forgot to set FD_CLOEXEC for the fd received from accept #518

Closed
YueHonghui opened this issue Nov 3, 2015 · 3 comments
Assignees
Labels
Bug It might be a bug. TransByAI Translated by AI/GPT.
Milestone

Comments

@YueHonghui
Copy link
Contributor

YueHonghui commented Nov 3, 2015

Forgot to set FD_CLOEXEC for the accepted fd, which will result in fd leakage when FORK FFMPEG.

TRANS_BY_GPT3

@winlinvip winlinvip added the Bug It might be a bug. label Nov 3, 2015
@winlinvip winlinvip added this to the srs 2.0 release milestone Nov 3, 2015
@winlinvip
Copy link
Member

winlinvip commented Nov 3, 2015

Can I submit a patch? git format-patch origin/develop will do, I haven't looked at this ioctl for a long time.

TRANS_BY_GPT3

@YueHonghui
Copy link
Contributor Author

YueHonghui commented Nov 16, 2015

Submitting a patch won't... Does submitting a PR work?

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Nov 16, 2015

PR is better than patch, haha.
😄

TRANS_BY_GPT3

@winlinvip winlinvip changed the title accept上来的fd忘了设置FD_CLOEXEC fd leak: accept上来的fd忘了设置FD_CLOEXEC Nov 16, 2015
@winlinvip winlinvip changed the title fd leak: accept上来的fd忘了设置FD_CLOEXEC fd leak when fork: accept上来的fd忘了设置FD_CLOEXEC Nov 16, 2015
@winlinvip winlinvip self-assigned this Sep 25, 2021
@winlinvip winlinvip changed the title fd leak when fork: accept上来的fd忘了设置FD_CLOEXEC fd leak when fork: forgot to set FD_CLOEXEC for the fd received from accept Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug It might be a bug. TransByAI Translated by AI/GPT.
Projects
None yet
Development

No branches or pull requests

2 participants