Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make api gateway optional and adjust api_base_auth var naming #40

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

Erin-Boehmer
Copy link
Contributor

@Erin-Boehmer Erin-Boehmer commented Sep 20, 2022

Addresses issue #22

In production environments, some teams will not want to use public-facing API Gateway resources. This PR makes API Gateway optional by adding a var to the metadata service enable_api_gateway. I also adjusted the api_basic_auth var to use the enable_ prefix, in keeping with the bool var naming in this repo.

@oavdeev oavdeev self-requested a review October 7, 2022 02:13
Copy link
Member

@oavdeev oavdeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would technically require the module user to change the param name, right? Just making note of this so i'll make it a minor release then, not a patch release

@Erin-Boehmer
Copy link
Contributor Author

This change would technically require the module user to change the param name, right? Just making note of this so i'll make it a minor release then, not a patch release

Hey @oavdeev - yes, this would be a minor release. I refactored the api_basic_auth to enable_api_basic_auth (within the metadata service module) and metadata_service_enable_api_basic_auth (at the metaflow module level). Also rebased against latest commits if you're ready to merge.

@oavdeev oavdeev merged commit 7c2368f into outerbounds:master Feb 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants