Add custom output path for the DB migrate lambda #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem where we were seeing Terraform config drift and unstable plans because the
db_migrate_lambda.zip
file was being written inside the terraform module folder, which can be outside the repo folder (e.g. ifTF_DATA_DIR
is set). That means there is no zip file (orindex.py
) available to a freshplan
and so TF detects a deletion.A solution to this is to commit or to cache the zip file across builds, but this TF module does not allow that location to be customised.
This PR makes two changes:
To test this: