[eks_argo] Add event triggering support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackie-ob
force-pushed
the
jackie-argo-events
branch
from
701ebe0 to
41085fc
Compare
…aflow-tools later
oavdeev
reviewed
Apr 19, 2023
|
|
||
| variable "with_public_ip" { | ||
| type = bool | ||
| default = true |
There was a problem hiding this comment.
doesn't seem to be used anywhere in this PR?
There was a problem hiding this comment.
TF won't apply without it... existing bug.
oavdeev
approved these changes
Apr 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of AWS. Argo events stuff has been put into a subfolder, TF module style. I expect to move this
argo_events/folder into metaflow-tools repo, and we will be referencing that instead in future(over TF / git protocol). This will give use DRY.