Skip to content

Commit f3e9aa5

Browse files
committed
refactor(database): use setCallback
1 parent bcb703a commit f3e9aa5

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/database/rawExecute.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { parseResponse } from '../utils/parseResponse';
55
import { executeType, parseExecute } from '../utils/parseExecute';
66
import { scheduleTick } from '../utils/scheduleTick';
77
import { isServerConnected, waitForConnection } from '../database';
8+
import { setCallback } from '../utils/setCallback'
89

910
export const rawExecute = async (
1011
invokingResource: string,
@@ -25,7 +26,9 @@ export const rawExecute = async (
2526

2627
const type = executeType(query);
2728
const placeholders = query.split('?').length - 1;
28-
parameters = parameters ? parseExecute(placeholders, parameters) : [];
29+
30+
cb = setCallback(parameters, cb);
31+
parameters = parseExecute(placeholders, parameters);
2932

3033
if (!isServerConnected) await waitForConnection();
3134

src/database/rawQuery.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { pool, isServerConnected, waitForConnection } from '.';
22
import { parseArguments } from '../utils/parseArguments';
3+
import { setCallback } from '../utils/setCallback';
34
import { parseResponse } from '../utils/parseResponse';
45
import { logQuery, printError, runProfiler } from '../logger';
56
import type { CFXCallback, CFXParameters } from '../types';
@@ -24,7 +25,8 @@ export const rawQuery = async (
2425
`Expected query to be a string but received ${typeof query} instead.`
2526
);
2627

27-
[query, parameters, cb] = parseArguments(invokingResource, query, parameters, cb);
28+
cb = setCallback(parameters, cb);
29+
[query, parameters] = parseArguments(invokingResource, query, parameters);
2830

2931
if (!isServerConnected) await waitForConnection();
3032

src/database/rawTransaction.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { printError, profileBatchStatements, runProfiler } from '../logger';
33
import { CFXCallback, CFXParameters, TransactionQuery } from '../types';
44
import { parseTransaction } from '../utils/parseTransaction';
55
import { scheduleTick } from '../utils/scheduleTick';
6+
import { setCallback } from '../utils/setCallback';
67

78
const transactionError = (queries: { query: string; params?: CFXParameters }[], parameters: CFXParameters) => {
89
`${queries.map((query) => `${query.query} ${JSON.stringify(query.params || [])}`).join('\n')}\n${JSON.stringify(
@@ -14,14 +15,15 @@ export const rawTransaction = async (
1415
invokingResource: string,
1516
queries: TransactionQuery,
1617
parameters: CFXParameters,
17-
callback?: CFXCallback,
18+
cb?: CFXCallback,
1819
isPromise?: boolean
1920
) => {
2021
if (!isServerConnected) await waitForConnection();
2122

2223
scheduleTick();
2324

24-
const { transactions, cb } = parseTransaction(invokingResource, queries, parameters, callback);
25+
cb = setCallback(parameters, cb);
26+
const transactions = parseTransaction(invokingResource, queries, parameters);
2527
const connection = await pool.getConnection();
2628
const hasProfiler = await runProfiler(connection, invokingResource);
2729
let response = false;

0 commit comments

Comments
 (0)