Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make OCS Share API always return URL #16488

Closed
rullzer opened this issue May 21, 2015 · 2 comments
Closed

Make OCS Share API always return URL #16488

rullzer opened this issue May 21, 2015 · 2 comments
Assignees
@rullzer
Labels
dev:ocs enhancement feature:sharing
Milestone
8.2

Comments

@rullzer
Copy link
Contributor

rullzer commented May 21, 2015

Currently the OCS Share API only returns the url on the creation of a share. It would be a good to also return the URL on retrieving of the shares.

Advantages:

  • This makes sure that the url is correct (since we use the URL generator to get the route) and not depend on a client getting the correct url.
  • If we would change the url in the future (maybe the index.php can go) client would directly get the new url
  • If somebody wants to write an app that uses some url shortner or whatever this should get easier.

Disadvantage:

  • Slightly more output in the OCS Share API calls
@rullzer rullzer self-assigned this May 21, 2015
@rullzer rullzer added this to the 8.2-next milestone May 21, 2015
@rullzer
Copy link
Contributor Author

rullzer commented May 21, 2015

Of course this only holds for link shares

@rullzer rullzer mentioned this issue May 22, 2015
Merged
@oparoz oparoz added the dev:ocs label Jun 25, 2015
@rullzer
Copy link
Contributor Author

rullzer commented Jul 16, 2015

Fixed in #16535

@rullzer rullzer closed this as completed Jul 16, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@rullzer rullzer

Labels
dev:ocs enhancement feature:sharing
Projects
None yet
Milestone
8.2
Development

No branches or pull requests
2 participants
@rullzer @oparoz