From 7711a9e1356d3a2ee69f9b8a85d05a91ca0e544e Mon Sep 17 00:00:00 2001 From: Christian Rebischke Date: Sat, 18 Dec 2021 14:23:41 +0100 Subject: [PATCH] fix: empty slice declaration using literal --- packageurl.go | 6 +++--- packageurl_test.go | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packageurl.go b/packageurl.go index bff4d2d..de54728 100644 --- a/packageurl.go +++ b/packageurl.go @@ -80,7 +80,7 @@ type Qualifier struct { } func (q Qualifier) String() string { - // A value must be must be a percent-encoded string + // A value must be a percent-encoded string return fmt.Sprintf("%s=%s", q.Key, url.PathEscape(q.Value)) } @@ -156,7 +156,7 @@ func (p *PackageURL) ToString() string { purl := fmt.Sprintf("pkg:%s/", p.Type) // Add namespaces if provided if p.Namespace != "" { - ns := []string{} + var ns []string for _, item := range strings.Split(p.Namespace, "/") { ns = append(ns, url.QueryEscape(item)) } @@ -276,7 +276,7 @@ func FromString(purl string) (PackageURL, error) { version = v name = name[:atIndex] } - namespaces := []string{} + var namespaces []string if index != -1 { remainder = remainder[:index] diff --git a/packageurl_test.go b/packageurl_test.go index f4e767d..052287d 100644 --- a/packageurl_test.go +++ b/packageurl_test.go @@ -187,7 +187,7 @@ func TestToStringExamples(t *testing.T) { t.Fatal(err) } // Load the json file contents into a structure - testData := []TestFixture{} + var testData []TestFixture err = json.Unmarshal(data, &testData) if err != nil { t.Fatal(err) @@ -225,7 +225,7 @@ func TestStringer(t *testing.T) { t.Fatal(err) } // Load the json file contents into a structure - testData := []TestFixture{} + var testData []TestFixture err = json.Unmarshal(data, &testData) if err != nil { t.Fatal(err)