Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

; (semi-colon) in TXT records causes the remainder of the record to be dropped on import #67

Closed
avsdev-cw opened this issue Sep 16, 2020 · 2 comments · Fixed by #73
Closed
Assignees
Labels

Comments

@avsdev-cw
Copy link

Describe the bug
; (semi-colon) in TXT records cause the remainder of the record to be dropped, eg:

_dmarc              IN TXT    "v=DMARC1; p=quarantine; rua=mailto:postmaster@domain.local; ruf=mailto:postmaster@comain.local; fo=1; adkim=r; aspf=r; pct=100; sp=quarantine"

Gets imported as:

_dmarc              IN TXT    "v=DMARC1;

The issue lies with the parser, it hits ; and assumes it is a comment marker, even though it is within a quote

To Reproduce
Import an existing zone file with TXT records with ; (semi-colon's) in them.

@pacoorozco pacoorozco self-assigned this Sep 16, 2020
@pacoorozco pacoorozco added the bug label Sep 16, 2020
@pacoorozco
Copy link
Owner

Hi @avsdev-cw

I've worked in a patch that is available for testing ay change-file-dns-parser branch. Can you test it?

@pacoorozco
Copy link
Owner

Fixed on v0.10.0.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants