Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add support for detecting the cgroup driver for CRI other than #874

Open
github-actions bot opened this issue Dec 14, 2020 · 0 comments
Open

add support for detecting the cgroup driver for CRI other than #874

github-actions bot opened this issue Dec 14, 2020 · 0 comments
Labels

Comments

@github-actions
Copy link

add support for detecting the cgroup driver for CRI other than

Docker. Currently only Docker driver detection is supported:

Discussion:

kubernetes/kubeadm#844

// TODO: add support for detecting the cgroup driver for CRI other than

Copyright 2018 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package util

import (
	"strings"

	"github.com/pkg/errors"

	utilsexec "k8s.io/utils/exec"
)

const (
	// CgroupDriverSystemd holds the systemd driver type
	CgroupDriverSystemd = "systemd"
	// CgroupDriverCgroupfs holds the cgroupfs driver type
	CgroupDriverCgroupfs = "cgroupfs"
)

// TODO: add support for detecting the cgroup driver for CRI other than
// Docker. Currently only Docker driver detection is supported:
// Discussion:
//     https://github.com/kubernetes/kubeadm/issues/844

// GetCgroupDriverDocker runs 'docker info -f "{{.CgroupDriver}}"' to obtain the docker cgroup driver
func GetCgroupDriverDocker(execer utilsexec.Interface) (string, error) {
	driver, err := callDockerInfo(execer)
	if err != nil {
		return "", err
	}
	return strings.TrimSuffix(driver, "\n"), nil
}

func callDockerInfo(execer utilsexec.Interface) (string, error) {
	out, err := execer.Command("docker", "info", "-f", "{{.CgroupDriver}}").Output()
	if err != nil {
		return "", errors.Wrap(err, "cannot execute 'docker info -f {{.CgroupDriver}}'")
	}
	return string(out), nil
}
ew file mode 100644
ndex 0000000000000..3d6b66373d3e8
++ b/cmd/kubeadm/app/util/cgroupdriver_test.go

073b567291c972acfc5342310613f2e082821b8a

@github-actions github-actions bot added the todo label Dec 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants