Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add .isolator_ignore support #40

Closed
viralpraxis opened this issue Nov 21, 2021 · 3 comments · Fixed by #41
Closed

Add .isolator_ignore support #40

viralpraxis opened this issue Nov 21, 2021 · 3 comments · Fixed by #41
Assignees
Labels
enhancement New feature or request

Comments

@viralpraxis
Copy link

viralpraxis commented Nov 21, 2021

The .isolator_todo.yml configuration file which is used to temporary ignore some parts of source code is a great feature, but its name might be misleading in case of code which intentionally contains some IO calls inside a transaction. IMO it'd be great if there was support for .isolator_ignore.yml or .isolatorignore.yml file with the same syntax as .isolator_todo.yml but different purpose. Current approach works perfectly with small development teams but if there are a lot of people working on making codebase sync with Isolator it might be a problem.

That's currently possible to implement a custom Ignorer class which respects both todo and ignore files but I think it'd be good to make it a built-in feature.

So, I'd like to suggest to add the configuration file which points to code that will not be fixed any time soon and keep .isolator_todo.yml as a TODO-list. Thanks for a great gem BTW.

@viralpraxis viralpraxis added the enhancement New feature or request label Nov 21, 2021
@palkan
Copy link
Owner

palkan commented Nov 30, 2021

Thanks for the proposal. Sounds reasonable.

We can call ignorer.prepare multiple times; so, supporting .isolator_ignore.yml could be as simple as adding one more line to

Isolator.config.ignorer&.prepare

Would you like to propose a PR?

@viralpraxis
Copy link
Author

Yep, I'll make a PR soon

@viralpraxis
Copy link
Author

PR is done :) @palkan

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants