Param decorators assume attrs[key] is not None just because key in attrs

[janluke]

The following lines cause a TypeError if one provide help=None:

click/src/click/decorators.py

Lines 244 to 245 in 8b48450

	if "help" in option_attrs:
	option_attrs["help"] = inspect.cleandoc(option_attrs["help"])

By the way, why is cleandoc called by the decorator and not by Option itself? The docstring says "all keyword arguments are forwarded unchanged (except cls)".

The same problem appears when passing cls=None (also with @argument):

click/src/click/decorators.py

Lines 246 to 247 in 8b48450

	OptionClass = option_attrs.pop("cls", Option)
	_param_memo(f, OptionClass(param_decls, **option_attrs))

I encountered this problem while writing a wrapper for the above decorators that explicitly list arguments for a better IDE support.

[davidism]

By the way, why is cleandoc called by the decorator and not by Option itself? The docstring says "all keyword arguments are forwarded unchanged (except cls)".

Good question, I've noticed this before as well. I think it's because cleandoc is mostly useful when getting the doc from a decorated function's docstring, not for manually written strings. Let's explore changing that with an 8.1.0 PR, to see if there are any unexpected side effects.

Can you open a separate issue for that?

[janluke]

I think it's because cleandoc is mostly useful when getting the doc from a decorated function's docstring, not for manually written strings

But option.help is never taken from the docstring. Probably it was put there for similarity with @command.

Let's explore changing that with an 8.1.0 PR, to see if there are any unexpected side effects.

There shouldn't be any problem in moving this processing into Option. I'll check it out.

Can you open a separate issue for that?

Yep.