Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

remove _unicodefun #2198

Closed
davidism opened this issue Feb 18, 2022 · 0 comments · Fixed by #2199
Closed

remove _unicodefun #2198

davidism opened this issue Feb 18, 2022 · 0 comments · Fixed by #2199
Assignees
@davidism
Milestone
8.1.0

Comments

@davidism
Copy link
Member

davidism commented Feb 18, 2022 •
edited
Loading

Same as pallets/werkzeug#1760, Python 3.7+ picks UTF-8 instead of ASCII for misconfigured systems. Since we are dropping Python 3.6, we can drop the check.

~ 
❯ LANG= LC_ALL= python3.6 -c 'import locale, codecs; print(codecs.lookup(locale.getpreferredencoding()).name)'
ascii

~ 
❯ LANG= LC_ALL= python3.7 -c 'import locale, codecs; print(codecs.lookup(locale.getpreferredencoding()).name)'
utf-8
@davidism davidism added this to the 8.1.0 milestone Feb 18, 2022
@davidism davidism self-assigned this Feb 18, 2022
@davidism davidism mentioned this issue Feb 18, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

remove utf-8 detection pallets/click
1 participant
@davidism