-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Click 8.1 changed the parameter order in click.Path #2235
Comments
This was in the middle of a long list of arguments with no meaningful order, and with a clear fix (I expected people used kwargs already in this context). Using |
The order being clear or not was not really at issue because it was documented in that specific order in the existing API without any statement that kwargs was the only assumed calling paradigm. I realize that we should not have been relying on the order but nothing told us we should not be relying on it. Maybe we are the only click users who aren't using kwargs... 😄 |
Hmm, I'll just put the parameter at the end until I can figure a better way to migrate to keyword-only args. |
Click 8.1.2 is available: https://pypi.org/project/click/8.1.2/ |
In #1962 (released as 8.1.x) the writable and readable parameters for the
click.Path
constructor changed order (and the executable parameter was not added at the end of the parameter list). This breaks code that was not using kwargs in the constructor.See for example the breakage from lsst/daf_butler#669.
We have switched to kwargs. The API is not requiring that it only be used with kwargs and so we had not used kwargs previously.
Please consider using the
*
parameter in the APIs that are assumed to be kwargs only as this would enforce the policy.Environment:
The text was updated successfully, but these errors were encountered: