Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing reset on should_strip_ansi causing cascading issues during other tests #2732

Closed
Tyl13 opened this issue May 22, 2024 · 0 comments
Closed

Missing reset on should_strip_ansi causing cascading issues during other tests #2732

Tyl13 opened this issue May 22, 2024 · 0 comments
Milestone
8.1.8

Comments

@Tyl13
Copy link
Contributor

Tyl13 commented May 22, 2024

PR #2729 was not resetting _compat.should_strip_ansi after replacing it with the mocked version. So the full pytest causes test_echo_color_flag to fail for windows machines.

Run pytest on test_utils.py with a Windows machine and observe the test that fails when it shouldn't be.

The test should not fail.

Environment:

  • Python version: 3.12.3
  • Click version: 8.1.x source code
  • OS: Windows
@Tyl13 Tyl13 mentioned this issue May 22, 2024
Merged
4 tasks
@davidism davidism modified the milestone: 8.1.8 May 22, 2024
@Tyl13 Tyl13 mentioned this issue May 23, 2024
Open
3 tasks
@davidism davidism closed this as completed Dec 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.8
Development

No branches or pull requests
2 participants
@davidism @Tyl13