Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for partitioned session cookies #5472

Closed
bookernath opened this issue Apr 30, 2024 · 4 comments · Fixed by #5499
Closed

Add support for partitioned session cookies #5472

bookernath opened this issue Apr 30, 2024 · 4 comments · Fixed by #5499
Milestone

Comments

@bookernath
Copy link

bookernath commented Apr 30, 2024

Related issue with historical context: pallets/werkzeug#2797

Partitioned cookies are now supported in Werkzeug: pallets/werkzeug#2855

It would be nice to have first-class support for the flask session cookie using the Partitioned flag to provide support for Chrome's CHIPS and allow sessions to continue to work within iframes.

Example usage might be:

app.config['SESSION_COOKIE_SAMESITE'] = "None"
app.config['SESSION_COOKIE_SECURE'] = True
app.config['SESSION_COOKIE_PARTITIONED'] = True # add this?
@davidism davidism added this to the 3.1.0 milestone Apr 30, 2024
@odanoburu

This comment was marked as off-topic.

@davidism

This comment was marked as off-topic.

@Josecespedesant
Copy link

Hi! I'd like to take a look into collaborate in this issue

I was going through the context of this issue and saw that implicitly if partitioned is set to true it should also set secure to true as mentioned here: https://github.com/pallets/werkzeug/pull/2855/files#diff-cd95d3a95564f3230d4875ac34fc9d039856b033c6b1430d5d3cc864f87cf89aL1300

Would that be the case for here as well?

@davidism
Copy link
Member

davidism commented May 27, 2024

Yes, but you shouldn't need to do anything extra for that, it's already how it's implemented, as you've linked to.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants