Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor PackageLoader to use importlib.resources #1978

Open
davidism opened this issue May 13, 2024 · 1 comment · May be fixed by #1985
Open

refactor PackageLoader to use importlib.resources #1978

davidism opened this issue May 13, 2024 · 1 comment · May be fixed by #1985
Milestone
3.2.0

Comments

@davidism
Copy link
Member

davidism commented May 13, 2024 •
edited
Loading

I had to ignore a failing test when adding 3.13 to the test matrix #1977, as the zip importer no longer exposes a private _files list for PackageLoader.list_templates to use. Presumably I didn't use importlib.resources before because I had to support older Python versions? Either way, should be able to now. Consider the importlib_resources backport for 3.7 and 3.8 so we can use the files API in all versions.
@danwuSBU
Copy link

looking at this at PyCon sprint

@danwuSBU danwuSBU linked a pull request May 21, 2024 that will close this issue
Open
@CheeseCake87 CheeseCake87 added this to the 3.2.0 milestone Dec 2, 2024
@dnicolodi dnicolodi mentioned this issue Jan 10, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Refactor PackageLoader to use importlib_resources danwuSBU/jinja
3 participants
@davidism @CheeseCake87 @danwuSBU