Skip to content

consolidate the duplicate definitions of NA values in code and docs (refactoring, cleaning) #16606

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
OlegShteynbuk opened this issue Jun 5, 2017 · 5 comments
Labels
Clean IO CSV read_csv, to_csv Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Milestone

Comments

@OlegShteynbuk
Copy link
Contributor

pull request for the code - #16589 (review)

@OlegShteynbuk
Copy link
Contributor Author

OlegShteynbuk commented Jun 5, 2017

docs - the file doc/source/io.rst repeats the same NA values in two places; keeping them in sync with the code might require an extra step of generating this file from a template file with placeholders.

@OlegShteynbuk
Copy link
Contributor Author

if currently docs consolidation is not realistic can split docs consolidation into a separate issue

@gfyoung
Copy link
Member

gfyoung commented Jun 5, 2017

@OlegShteynbuk : What you could do instead is reference the NA values in the first location when you get to the second location (and include a link to the location within the doc).

@jreback jreback added Clean IO CSV read_csv, to_csv Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Jun 6, 2017
@jreback jreback added this to the 0.21.0 milestone Jun 6, 2017
@OlegShteynbuk
Copy link
Contributor Author

OlegShteynbuk commented Jun 7, 2017

repetition of the same NA values in docs was removed; the first location has reference to the second location as suggested by gfyoung.

the na values in the docs should be consistent now.

@jorisvandenbossche
Copy link
Member

This was closed by #16589 I think

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Clean IO CSV read_csv, to_csv Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

No branches or pull requests

4 participants