Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DEPR: Certain Grouper and Grouping attributes #56148

Closed
rhshadrach opened this issue Nov 24, 2023 · 0 comments · Fixed by #56149
Closed

DEPR: Certain Grouper and Grouping attributes #56148

rhshadrach opened this issue Nov 24, 2023 · 0 comments · Fixed by #56149
Assignees
@rhshadrach
Labels
Deprecate Functionality to remove in pandas Groupby Refactor Internal refactoring of code
Milestone
2.2

Comments

@rhshadrach
Copy link
Member

rhshadrach commented Nov 24, 2023 •
edited
Loading

#55738 reworks some of the internals for groupby, the following attributes are no longer necessary.

  • BaseGrouper.group_keys_seq
  • BaseGrouper.reconstructed_codes
  • Grouping.group_index
  • Grouping.result_index
  • Grouping.group_arraylike

I'd expect these to be almost exclusively used internally in pandas, but since they are publicly accessible I think we should deprecate these and remove them in 3.0.
@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby Deprecate Functionality to remove in pandas labels Nov 24, 2023
@rhshadrach rhshadrach added this to the 2.2 milestone Nov 24, 2023
@rhshadrach rhshadrach self-assigned this Nov 24, 2023
@rhshadrach rhshadrach mentioned this issue Nov 24, 2023
Merged
5 tasks
@singjc singjc mentioned this issue Nov 28, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rhshadrach rhshadrach

Labels
Deprecate Functionality to remove in pandas Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

DEPR: Some Grouper and Grouping attributes rhshadrach/pandas
1 participant
@rhshadrach