Skip to content

Priority issues with jsGlobals #1243

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
rschristian opened this issue Nov 1, 2021 · 0 comments
Open

Priority issues with jsGlobals #1243

rschristian opened this issue Nov 1, 2021 · 0 comments

Comments

@rschristian
Copy link

Requisite minimal reproducible example, formatted as plain text :

.parse(process.argv, {
    unknown: (arg) => `Unknown option: ${arg}`,
});

Example of problematic highlighting as well as working highlighting


The issue I'm running into is that globals (and maybe some other highlighting groups as well, I haven't done a comprehensive check) have a lower priority than the function parameters highlight group. In the example above, process.argv is passed as a parameter but is missing the highlighting for being a global. If I were to move this out of the function call, the correct highlighting is applied.

This is of course a super minor issue, but I thought I'd open it for tracking as I haven't seen any references. I could also be in the minority here, certainly possible for this to be intentional that globals have a lower priority than function parameters when it comes to highlighting.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant